JooHyukKim commented on code in PR #20599: URL: https://github.com/apache/pulsar/pull/20599#discussion_r1233062680
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -18,7 +18,7 @@ Fixes #xyz <!-- or this PR is one task of an issue --> -Master Issue: #xyz +Parent Issue: #xyz Review Comment: You think? @tisonkun ? I should have mentioned that I conidered `main`, but the word `main` seems to limit how nested issues & PRs can get. For example, C depends on B and B depends on A. If we say B is main issue of C, it sounds like B is the main. Well, that is my perspective. With respect to Github's attitude, main serves as "default" branch (kind of different position), where this PR's parent serves like an upper/super issue as in OOP perspective. Hope I am explaining this alright. 😅 ########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -18,7 +18,7 @@ Fixes #xyz <!-- or this PR is one task of an issue --> -Master Issue: #xyz +Parent Issue: #xyz Review Comment: For example, C depends on B and B depends on A. If we say B is main issue of C, it sounds like B is the main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
