gaoran10 opened a new pull request, #20605: URL: https://github.com/apache/pulsar/pull/20605
### Motivation In PR https://github.com/apache/pulsar/pull/14506, we remove the useless config `managedLedgerNumWorkerThreads` but we didn't remove the config from the config file, if users use this configuration, the Pulsar SQL can't startup due to `strictConfig` mode, remove this useless configuration for Pulsar SQL. ``` // at this point all config file properties should be used // so we can calculate the unused properties unusedProperties.keySet().removeAll(configurationFactory.getUsedProperties()); for (String key : unusedProperties.keySet()) { Message message = new Message(format("Configuration property '%s' was not used", key)); (strictConfig ? errors : warnings).add(message); } // If there are configuration errors, fail-fast to keep output clean if (!errors.isEmpty()) { throw new ApplicationConfigurationException(errors, warnings); } ``` ### Modifications Remove useless configuration `pulsar.managed-ledger-num-worker-threads` from the config file. ### Verifying this change Add tests for the annotated configurations. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
