michaeljmarshall commented on code in PR #20563:
URL: https://github.com/apache/pulsar/pull/20563#discussion_r1235922016


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1454,10 +1450,6 @@ public ScheduledExecutorService getExecutor() {
         return executor;
     }
 
-    public ScheduledExecutorService getCacheExecutor() {
-        return cacheExecutor;
-    }

Review Comment:
   This is technically a breaking change for pulsar extensions. I don't know of 
any extensions using it, but it seems risky to just remove the method. 
@BewareMyPower - what is your opinion on the right way to handle these kinds of 
methods that could be used by extensions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to