heesung-sn commented on code in PR #20566:
URL: https://github.com/apache/pulsar/pull/20566#discussion_r1235946925
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3304,10 +3305,19 @@ private CompletableFuture<Boolean>
isAllowAutoTopicCreationAsync(final TopicName
topicName.getNamespaceObject());
return CompletableFuture.completedFuture(false);
}
- //System topic can always be created automatically
+
+ // ServiceUnitStateChannelImpl.TOPIC expects to be a
non-partitioned-topic now.
+ // We don't allow the auto-creation here.
+ // ServiceUnitStateChannelImpl.start() is responsible to create the
topic.
+ if (ServiceUnitStateChannelImpl.TOPIC.equals(topicName.toString())) {
Review Comment:
I am not sure if I understood your question. Since the system topic is
currently expected to work on a non-partitioned topic, we specifically create
the topic in ServiceUnitStateChannelImpl.start(). This change will block the
system topic auto-creation(when any other broker tries to auto-create the topic
due to any race-condition )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
