D-2-Ed commented on code in PR #610:
URL: https://github.com/apache/pulsar-site/pull/610#discussion_r1236170788
##########
docs/developers-landing.md:
##########
@@ -22,4 +13,13 @@ If you want to read top-viewed docs for developers, check
out the following conc
- [Pulsar APIs](pulsar-api-overview.md)
- [Pulsar admin APIs](admin-api-overview.md)
- [Pulsar REST APIs](reference-rest-api-overview.md)
-- [Pulsar contribution guide](../../contribute)
\ No newline at end of file
+- [Pulsar contribution guide](../../contribute)
+
+## Advanced topics
+
+If you want to learn how to develop Pulsar related components, check out the
following guides.
Review Comment:
Add a hyphen to "Pulsar-related components"
I don't think the items in the list are "guides?" It might be better to say,
"...check out the following topics" or "...check out the following documents"
##########
docs/developers-landing.md:
##########
@@ -22,4 +13,13 @@ If you want to read top-viewed docs for developers, check
out the following conc
- [Pulsar APIs](pulsar-api-overview.md)
- [Pulsar admin APIs](admin-api-overview.md)
- [Pulsar REST APIs](reference-rest-api-overview.md)
-- [Pulsar contribution guide](../../contribute)
\ No newline at end of file
+- [Pulsar contribution guide](../../contribute)
+
+## Advanced topics
+
+If you want to learn how to develop Pulsar related components, check out the
following guides.
+
+- [Develop simulation tools](develop-tools.md)
+- [Develop binary protocol](developing-binary-protocol.md)
+- [Develop load manager](develop-load-manager.md)
Review Comment:
Should this be "Enable the load manager"?
##########
docs/developers-landing.md:
##########
@@ -22,4 +13,13 @@ If you want to read top-viewed docs for developers, check
out the following conc
- [Pulsar APIs](pulsar-api-overview.md)
- [Pulsar admin APIs](admin-api-overview.md)
- [Pulsar REST APIs](reference-rest-api-overview.md)
-- [Pulsar contribution guide](../../contribute)
\ No newline at end of file
+- [Pulsar contribution guide](../../contribute)
+
+## Advanced topics
+
+If you want to learn how to develop Pulsar related components, check out the
following guides.
+
+- [Develop simulation tools](develop-tools.md)
+- [Develop binary protocol](developing-binary-protocol.md)
+- [Develop load manager](develop-load-manager.md)
+- [Develop Pulsar plugin](develop-plugin.md)
Review Comment:
Change to "Develop plugins for Pulsar"
##########
docs/developers-landing.md:
##########
@@ -22,4 +13,13 @@ If you want to read top-viewed docs for developers, check
out the following conc
- [Pulsar APIs](pulsar-api-overview.md)
- [Pulsar admin APIs](admin-api-overview.md)
- [Pulsar REST APIs](reference-rest-api-overview.md)
-- [Pulsar contribution guide](../../contribute)
\ No newline at end of file
+- [Pulsar contribution guide](../../contribute)
+
+## Advanced topics
+
+If you want to learn how to develop Pulsar related components, check out the
following guides.
+
+- [Develop simulation tools](develop-tools.md)
+- [Develop binary protocol](developing-binary-protocol.md)
Review Comment:
Should this be, "Develop with the binary protocol?"
##########
docs/developers-landing.md:
##########
@@ -4,15 +4,6 @@ title: Pulsar for Developers
sidebar_label: "Pulsar for Developers"
---
-## Advanced topics
-
-If you want to learn how to develop Pulsar related components, check out the
following guides.
-
-- [Develop simulation tools](develop-tools.md)
-- [Develop binary protocol](developing-binary-protocol.md)
-- [Develop load manager](develop-load-manager.md)
-- [Develop Pulsar plugin](develop-plugin.md)
-
## Popular topics
If you want to read top-viewed docs for developers, check out the following
concepts, examples, and tutorials.
Review Comment:
add "the" and spell out "docs" - should be "documents"
"If you want to read the top-viewed documents for...."
##########
docs/developers-landing.md:
##########
@@ -22,4 +13,13 @@ If you want to read top-viewed docs for developers, check
out the following conc
- [Pulsar APIs](pulsar-api-overview.md)
- [Pulsar admin APIs](admin-api-overview.md)
- [Pulsar REST APIs](reference-rest-api-overview.md)
-- [Pulsar contribution guide](../../contribute)
\ No newline at end of file
+- [Pulsar contribution guide](../../contribute)
+
+## Advanced topics
+
+If you want to learn how to develop Pulsar related components, check out the
following guides.
+
+- [Develop simulation tools](develop-tools.md)
Review Comment:
To more accurately represent what is discussed in this doc, should this be
titeld, "Create a test environment"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
