massakam opened a new pull request, #20629: URL: https://github.com/apache/pulsar/pull/20629
Fixes #20615 ### Motivation `SimpleProducerConsumerStatTest#testMsgRateExpired` seems flakey, so I'll try to improve it. ### Modifications Before this fix, we checked if the messages expired by referring to the `msgRateExpired` value in the subscription stats. However, this value resets to 0 over time, so we instead refer to the `totalMsgExpired` value, which never resets. Additionally, we get the stats directly from the instances in the broker server and not from the admin API. ### Verifying this change - [ ] Make sure that the change passes the CI checks. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
