hangc0276 commented on code in PR #20602:
URL: https://github.com/apache/pulsar/pull/20602#discussion_r1241141347
##########
pom.xml:
##########
@@ -162,11 +162,11 @@ flexible messaging model and an intuitive client
API.</description>
<docker-maven.version>0.42.1</docker-maven.version>
<docker.verbose>true</docker.verbose>
<typetools.version>0.5.0</typetools.version>
- <protobuf3.version>3.19.6</protobuf3.version>
+ <protobuf3.version>3.22.3</protobuf3.version>
Review Comment:
Protobuf 3.22.0 introduces a breaking change. It requires all the
sub-project, which depend on the bookkeeper to upgrade Protobuf to 3.22.0+
https://github.com/apache/bookkeeper/pull/4001.
We use [lightproto](https://github.com/splunk/lightproto) to compile
Protobuf code to Java code and the lightproto uses Protobuf 3.13.0. Do we need
to upgrade lightproto's Protobuf version first before upgrading Pulsar's
Protobuf version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
