codelipenghui commented on code in PR #20647:
URL: https://github.com/apache/pulsar/pull/20647#discussion_r1241867649
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -455,23 +455,17 @@ public synchronized void producerRemoved(String
producerName) {
public synchronized void purgeInactiveProducers() {
Review Comment:
I think we don't need it, and I also want to remove it in this PR initially.
But considering it is not related to the publish latency spike issue, maybe
we'd better just keep this PR only for the publish latency spike issue. And I
can create the following PR to remove this `synchronized`, but no need to
cherry-pick to release branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
