Technoboy- commented on PR #20472:
URL: https://github.com/apache/pulsar/pull/20472#issuecomment-1610627474

   > @Technoboy- Since the indicator name has been changed, could you please 
help add a test to avoid regression?
   
   I thought the current tests might cover this, but they didn't.  So I have 
added the tests. Also during adding the tests, I find the indicator name should 
be "pulsar_xxx", not "brk_xxx", please also review again.
   @codelipenghui @Demogorgon314 @hangc0276 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to