gunli commented on code in PR #1039:
URL: https://github.com/apache/pulsar-client-go/pull/1039#discussion_r1244741012


##########
pulsar/producer_partition.go:
##########
@@ -752,6 +755,14 @@ func (p *partitionProducer) updateMetadataSeqID(mm 
*pb.MessageMetadata, msg *Pro
        }
 }
 
+func (p *partitionProducer) updateSingleMessageMetadataSeqID(smm 
*pb.SingleMessageMetadata, msg *ProducerMessage) {

Review Comment:
   I know that `updateSingleMessageMetadataSeqID` is not reused by other 
functions rather than `genSingleMessageMetadataInBatch`, I asctracted it as a 
method is in the purpose of that making the code is easy to maintain, we can 
know that we update the meta seqID with a same manner  obvoiusly both for 
`MetadataSeqID` and `SingleMessageMetadataSeqID`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to