JooHyukKim commented on code in PR #20646:
URL: https://github.com/apache/pulsar/pull/20646#discussion_r1245276494
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java:
##########
@@ -2289,7 +2291,7 @@ private class SetOffloadPolicies extends CliCommand {
@Parameter(
names = {"--offloadAfterThresholdInSeconds", "-oats"},
- description = "Offload after threshold seconds (eg: 1,5,10)",
+ description = "Offload after threshold seconds (or
minutes,hours,days,weeks eg: 100m, 3h, 2d, 5w).",
required = false
)
Review Comment:
I found a possibly neat solution to isolate parsing logic that eventually
can be applied.
```suggestion
description = "Offload after threshold seconds (or
minutes,hours,days,weeks eg: 100m, 3h, 2d, 5w).",
required = false, converter =
TimeUnitToSecondConverter.class)
)
```
or you can refer to the revisions in my PR
https://github.com/apache/pulsar/pull/20663/files#r1245268820 for more
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
