BewareMyPower commented on code in PR #20595:
URL: https://github.com/apache/pulsar/pull/20595#discussion_r1245289003
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -905,9 +909,11 @@ public void connectionOpened(final ClientCnx cnx) {
// consumer was subscribed and connected but we got some
error, keep trying
reconnectLater(e.getCause());
Review Comment:
Good catch, I added `duringConnect.set(false)` in `reconnectLater` to ensure
the `duringConnect` is false when the `reconnectLater` method is called outside
by the `Connection` implementations.
Ideally, it's better to disallow the implementation class to call
`reconnectLater` but it's another topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
