JooHyukKim commented on code in PR #20651:
URL: https://github.com/apache/pulsar/pull/20651#discussion_r1250068304
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java:
##########
@@ -157,9 +157,6 @@ public void testShutDownWithMaxConcurrentUnload() throws
Exception {
assertEquals(list.size(), 1);
admin.brokers().shutDownBrokerGracefully(1, false);
//We can only unload one bundle per second, so it takes at least 2
seconds.
- Awaitility.await().atLeast(bundleNum - 1,
TimeUnit.SECONDS).untilAsserted(() -> {
Review Comment:
> Why delete this?
Because by this PR's changes, by the time
`admin.brokers().shutDownBrokerGracefully(1, false);` in line 158 returns,
closeAsync is already running and `pulsar.getBrokerService()` will return
`null` in most cases.
> And the notes should be deleted too?
True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
