315157973 commented on code in PR #20649:
URL: https://github.com/apache/pulsar/pull/20649#discussion_r1250785201
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2451,15 +2451,15 @@ private void trimConsumedLedgersInBackground() {
@Override
public void trimConsumedLedgersInBackground(CompletableFuture<?> promise) {
- executor.execute(() -> internalTrimConsumedLedgers(promise));
+ scheduledExecutor.execute(() -> internalTrimConsumedLedgers(promise));
}
public void trimConsumedLedgersInBackground(boolean isTruncate,
CompletableFuture<?> promise) {
Review Comment:
> if yes[Q-1], this patch doesn't have much effect on this issue, right?[Q-2]
Assuming that one trim task increase 0.01ms, if there are tens of
thousands of partitions, it will increase a lot.
Especially when there are many small packets sent to the cluster， this
situation will get worse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
