BewareMyPower commented on code in PR #20597:
URL: https://github.com/apache/pulsar/pull/20597#discussion_r1252559051
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -57,9 +59,10 @@ public class PersistentMessageExpiryMonitor implements
FindEntryCallback {
expirationCheckInProgressUpdater = AtomicIntegerFieldUpdater
.newUpdater(PersistentMessageExpiryMonitor.class,
"expirationCheckInProgress");
- public PersistentMessageExpiryMonitor(String topicName, String
subscriptionName, ManagedCursor cursor,
- PersistentSubscription subscription)
{
- this.topicName = topicName;
+ public PersistentMessageExpiryMonitor(PersistentTopic topic, String
subscriptionName, ManagedCursor cursor,
+ @Nullable PersistentSubscription
subscription) {
Review Comment:
This PR modifies the public API (even it's in the `pulsar-broker` module),
we should not cherry-pick it to release branches unless we make it compatible.
@poorbarcode @Technoboy-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
