entvex commented on code in PR #162:
URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1253121610
##########
tests/DotPulsar.Tests/ProducerTests.cs:
##########
@@ -63,6 +63,10 @@ public async Task
SimpleProduceConsume_WhenSendingMessagesToProducer_ThenReceive
(await consumer.Receive()).Value().Should().Be(content);
}
+ //TODO when sending to a topic with a single partition,
MessageId.partition it should be -1
Review Comment:
Good idea
##########
tests/DotPulsar.Tests/ProducerTests.cs:
##########
@@ -63,6 +63,10 @@ public async Task
SimpleProduceConsume_WhenSendingMessagesToProducer_ThenReceive
(await consumer.Receive()).Value().Should().Be(content);
}
+ //TODO when sending to a topic with a single partition,
MessageId.partition it should be -1
+
+ //TODO when sending to a topic multi partition topic, MessageId.partition
it should be not only be -1.
+
Review Comment:
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
