michaeljmarshall opened a new pull request, #20733: URL: https://github.com/apache/pulsar/pull/20733
### Motivation This PR removes an incorrect implementation of the websocket proxy ping/pong feature. The feature was requested here https://github.com/apache/pulsar/issues/10014. When it was implemented in https://github.com/apache/pulsar/pull/10035, it was added as an endpoint instead of as support for every endpoint, like our `/producer`, `/consumer`, and `/reader` endpoints. Notably, these endpoint already have support through the framework, so there is no reason for the `/pingpong` endpoint. I propose we remove it. Note: since this endpoint should not be used by anyone, I propose we cherry pick this to all active branches. ### Modifications * Remove the `/ws/pingpong` and the `/ws/v2/pingpong` endpoints and all associated code ### Verifying this change A test is modified to prove that the framework gives us the ping/pong support out of the box. ### Does this pull request potentially affect one of the following parts: Removes an unnecessary endpoint. ### Documentation - [x] `doc-not-needed` Ping/pong support is not documented here https://pulsar.apache.org/docs/3.0.x/client-libraries-websocket/, so I think we are good to skip docs. ### Matching PR in forked repository PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
