mattisonchao commented on code in PR #20496:
URL: https://github.com/apache/pulsar/pull/20496#discussion_r1255242109
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -843,16 +813,9 @@ private CompletableFuture<Void>
internalRemovePartitionsTopicNoAutocreationDisab
}).collect(Collectors.toList()));
}
- private CompletableFuture<Void>
internalRemovePartitionsAuthenticationPoliciesAsync(int numPartitions) {
+ private CompletableFuture<Void>
internalRemovePartitionsAuthenticationPoliciesAsync() {
Review Comment:
I saw `removePermissionsAsync` only deleted the parent info but no sub info
in `internalRemovePartitionsAuthenticationPoliciesAsync` method.
Do you mean the rest of the sub info will delete by
`BrokerService#deleteTopic`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
