mattisonchao commented on code in PR #20718:
URL: https://github.com/apache/pulsar/pull/20718#discussion_r1257619141
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##########
@@ -626,4 +633,57 @@ public void recycle() {
recyclerHandle.recycle(this);
}
}
+
+ public static void readCompactedEntries(TopicCompactionService
topicCompactionService, ManagedCursor cursor,
Review Comment:
How about moving this logic into the `Dispatchers` util class? Because it's
a static method, and it's weird for the eco-system to call it in
[PersistentDispatcherSingleActiveConsumer.java](https://github.com/apache/pulsar/pull/20718/files?diff=split&w=1#diff-cf3d6c439d725b9688d46adb393e4f36ec0470b201101c1f38e0e90d145cf0b6)
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
