congbobo184 commented on code in PR #20741:
URL: https://github.com/apache/pulsar/pull/20741#discussion_r1258086004
##########
pulsar-io/elastic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchSinkTests.java:
##########
@@ -243,6 +243,46 @@ public Schema answer(InvocationOnMock invocation) throws
Throwable {
verify(mockRecord, times(1)).ack();
}
+ @Test
+ public final void sendJsonStringSchemaTest() throws Exception {
+
+ when(mockRecord.getMessage()).thenAnswer(new
Answer<Optional<Message<String>>>() {
+ @Override
+ public Optional<Message<String>> answer(InvocationOnMock
invocation) throws Throwable {
+ final MessageImpl mock = mock(MessageImpl.class);
+
when(mock.getData()).thenReturn("{\"a\":1}".getBytes(StandardCharsets.UTF_8));
+ return Optional.of(mock);
+ }
+ });
+
+ when(mockRecord.getKey()).thenAnswer(new Answer<Optional<String>>() {
+ public Optional<String> answer(InvocationOnMock invocation) throws
Throwable {
+ return Optional.empty();
+ }
+ });
+
+ GenericRecord genericRecord = mock(GenericRecord.class);
+ when(genericRecord.getNativeObject()).thenReturn("{\"a\":1}");
+ when(genericRecord.getSchemaType()).thenReturn(SchemaType.JSON);
+ when(mockRecord.getValue()).thenAnswer(new Answer<GenericRecord>() {
+ public GenericRecord answer(InvocationOnMock invocation) throws
Throwable {
+ return genericRecord;
+ }
+ });
+
+ when(mockRecord.getSchema()).thenAnswer(new Answer<Schema>() {
+ public Schema answer(InvocationOnMock invocation) throws Throwable
{
+ return Schema.JSON(String.class);
+ }
+ });
+
+ map.put("indexName", "test-index");
+ map.put("schemaEnable", "true");
+ sink.open(map, mockSinkContext);
+ sink.write(mockRecord);
+ verify(mockRecord, times(1)).ack();
Review Comment:
may be we should add a test for the exception that you added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
