Technoboy- commented on code in PR #20713:
URL: https://github.com/apache/pulsar/pull/20713#discussion_r1259432828
##########
pulsar-broker-auth-sasl/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderSasl.java:
##########
@@ -72,6 +75,10 @@ public class AuthenticationProviderSasl implements
AuthenticationProvider {
private JAASCredentialsContainer jaasCredentialsContainer;
private String loginContextName;
+ private Cache<Long, AuthenticationState> authStates;
+
+ private static final String AUTHENTICATION_SASL_PREFIX =
"authentication_sasl_prefix";
+ private static final long AUTHENTICATION_SASL_DEFAULT_EXPIRE_MS = 60_000;
Review Comment:
AuthenticationProviderSasl is an extension implementation, it is a bit
inappropriate to put these in broker.conf.
SaslConstants is much more better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
