fundaev opened a new pull request, #301: URL: https://github.com/apache/pulsar-client-cpp/pull/301
### Motivation `ClientConnection::newGetLastMessageId` method uses `ClientConnection::sendRequestWithId` one to send request. It adds a new node into `ClientConnection::pendingRequests_` map. However `ClientConnection::handleGetLastMessageIdResponse` method does not affect this map. As a result the size of mentioned map is increased every time when `Reader::getLastMessageIdAsync` method is called. ### Modifications `ClientConnection::newGetLastMessageId` method use now `ClientConnection::sendCommand` one to send request. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as ConsumerTest.testGetLastMessageId and ConsumerTest.testGetLastMessageIdBlockWhenConnectionDisconnected. ### Documentation - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [x] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
