lifepuzzlefun commented on PR #20800: URL: https://github.com/apache/pulsar/pull/20800#issuecomment-1635278642
@BewareMyPower 你好，我来澄清一下 你说到的代码问题，这个pr https://github.com/apache/pulsar/pull/20597 hard to read的原因是因为这里有一个bug，这个patch之前的代码是不允许用户调用admin api来重置offset的，不是一个『the unrelated changes』而且这里的代码风格是 从first init comment 提交的时候带过来的。 <img width="1449" alt="image" src="https://github.com/apache/pulsar/assets/13600283/54890ae6-2858-45ac-bab9-691ed8d700b7";> 这个pr很棒，而且我觉得提高了代码的可读性，但是我觉得很容易对代码的reviewer产生对我本人后续patch的误会。maybe you can just tell people this is a refactoring pr but not with some insult words ok ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
