RobertIndie commented on code in PR #1049:
URL: https://github.com/apache/pulsar-client-go/pull/1049#discussion_r1263590995
##########
pulsar/producer_partition.go:
##########
@@ -851,13 +851,16 @@ func (p *partitionProducer) internalSingleSend(mm
*pb.MessageMetadata,
p._getConn().WriteData(buffer)
}
+type pendingItemCallback func(err error)
+
type pendingItem struct {
sync.Mutex
buffer internal.Buffer
sequenceID uint64
sentAt time.Time
sendRequests []interface{}
completed bool
+ callback pendingItemCallback
Review Comment:
How about naming it as `flushCallback` since this callback is only used in
the flush logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
