BewareMyPower commented on code in PR #20666:
URL: https://github.com/apache/pulsar/pull/20666#discussion_r1266106551
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/filter/BrokerFilter.java:
##########
@@ -42,9 +42,8 @@ public interface BrokerFilter {
* @param context The load manager context.
* @return Filtered broker list.
*/
- Map<String, BrokerLookupData> filter(Map<String, BrokerLookupData> brokers,
- ServiceUnitId serviceUnit,
- LoadManagerContext context)
- throws BrokerFilterException;
+ CompletableFuture<Map<String, BrokerLookupData>> filter(Map<String,
BrokerLookupData> brokers,
+ ServiceUnitId
serviceUnit,
+ LoadManagerContext
context);
Review Comment:
Yes. It's okay. But since a new method is added into the `BrokerFilter`, we
should still avoid cherry-picking it to release branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
