poorbarcode commented on code in PR #20823:
URL: https://github.com/apache/pulsar/pull/20823#discussion_r1266423667
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -1065,7 +1066,17 @@ public boolean trackDelayedDelivery(long ledgerId, long
entryId, MessageMetadata
delayedDeliveryTracker.get().resetTickTime(topic.getDelayedDeliveryTickTimeMillis());
long deliverAtTime = msgMetadata.hasDeliverAtTime() ?
msgMetadata.getDeliverAtTime() : -1L;
- return delayedDeliveryTracker.get().addMessage(ledgerId, entryId,
deliverAtTime);
+ try {
+ return delayedDeliveryTracker.get().addMessage(ledgerId,
entryId, deliverAtTime);
+ } catch (OutOfDirectMemoryError ex) {
Review Comment:
Just like the implementation of JVM, if could not allocate more memory, the
progress will be killed by OOM. It did not do `yield` and try another once.
>> Set the maximum memory usage of the delay message. If the delay message
usage exceeds the maximum memory usage, stuck new read
> This is an ideal approach. what is the good time value to recover?
In this patch, you mv this message into `replay queue`, and the next reading
will get it again, loop. The result is actually the same as doing a stuck new
read.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -1065,7 +1066,17 @@ public boolean trackDelayedDelivery(long ledgerId, long
entryId, MessageMetadata
delayedDeliveryTracker.get().resetTickTime(topic.getDelayedDeliveryTickTimeMillis());
long deliverAtTime = msgMetadata.hasDeliverAtTime() ?
msgMetadata.getDeliverAtTime() : -1L;
- return delayedDeliveryTracker.get().addMessage(ledgerId, entryId,
deliverAtTime);
+ try {
+ return delayedDeliveryTracker.get().addMessage(ledgerId,
entryId, deliverAtTime);
+ } catch (OutOfDirectMemoryError ex) {
+ log.error("Out of direct memory while trying add message index
to delayed tracker."
+ + " fallback to redelivery messages(heap) and waiting
for enough direct memory space."
+ + " error info: {}", ex.getMessage());
+ // fall back to redelivery queue(heap) waiting for enough
direct memory.
+ redeliveryMessages.add(ledgerId, entryId);
Review Comment:
This makes the delayed messages never delay, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
