Gleiphir2769 commented on PR #1059: URL: https://github.com/apache/pulsar-client-go/pull/1059#issuecomment-1641435619
Hi @graysonzeng. I think dataChan should be cleared in the `internalFlush`. Because `internalFlush` should guarantee flush all the messages in the dataChan too. I submit a fix PR in #1058 and I think `internalClose` can just invoke `internalFlush` to clear `dataChan`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
