michaeljmarshall opened a new pull request, #1061: URL: https://github.com/apache/pulsar-client-go/pull/1061
### Motivation This change is the same as https://github.com/apache/pulsar/pull/13161 and https://github.com/apache/pulsar/pull/16616, and is justified by these lines of our binary protocol spec: * https://github.com/apache/pulsar-site/blob/9b4b3d39014bd47c0bb9f66742b89bcb40ed7f07/docs/developing-binary-protocol.md?plain=1#L301-L304 * https://github.com/apache/pulsar-site/blob/9b4b3d39014bd47c0bb9f66742b89bcb40ed7f07/docs/developing-binary-protocol.md?plain=1#L468-L471 ### Modifications * When a producer or a consumer times out during creation, make an attempt to close the producer or consumer by sending the appropriate close command. Failures can safely be ignored because the only time that the close will actually matter is when the TCP connection is open for other protocol messages. The one nuance is that we send the close command to the same address pair that we send the create command. ### Verifying this change I tried to find a way to test this change, but I didn't see a good way. It'd be very valuable to have a low level tool to test these kinds of details for all of the non-java clients, but since one doesn't exist, I suggest we merge this as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
