massakam commented on PR #338: URL: https://github.com/apache/pulsar-client-node/pull/338#issuecomment-1643760937
Removed file extensions from all `require` statements because ESLint started throwing errors. ```sh $ npm run lint > [email protected] lint > clang-format-lint src/*.cc src/*.h && eslint --ext .js . /home/massakam/github/pulsar-client-node/GenCertFile.js 20:24 error Unexpected use of file extension "js" for "./src/Client.js" import/extensions /home/massakam/github/pulsar-client-node/index.js 21:35 error Unexpected use of file extension "js" for "./src/AuthenticationTls.js" import/extensions 22:38 error Unexpected use of file extension "js" for "./src/AuthenticationAthenz.js" import/extensions 23:37 error Unexpected use of file extension "js" for "./src/AuthenticationToken.js" import/extensions 24:38 error Unexpected use of file extension "js" for "./src/AuthenticationOauth2.js" import/extensions 25:24 error Unexpected use of file extension "js" for "./src/Client.js" import/extensions /home/massakam/github/pulsar-client-node/pkg/load_test.js 20:24 error Unexpected use of file extension "js" for "../index.js" import/extensions /home/massakam/github/pulsar-client-node/tests/client.test.js 20:29 error Unexpected use of file extension "js" for "./http_utils.js" import/extensions 21:24 error Unexpected use of file extension "js" for "../index.js" import/extensions /home/massakam/github/pulsar-client-node/tests/consumer.test.js 20:24 error Unexpected use of file extension "js" for "../index.js" import/extensions /home/massakam/github/pulsar-client-node/tests/end_to_end.test.js 21:24 error Unexpected use of file extension "js" for "../index.js" import/extensions 312:14 warning Unexpected constant condition no-constant-condition 357:26 warning 'message' is defined but never used no-unused-vars 357:35 warning 'reader' is defined but never used no-unused-vars 389:5 warning Test has no assertions jest/expect-expect 425:20 warning 'message' is defined but never used no-unused-vars 425:29 warning 'messageConsumer' is defined but never used no-unused-vars 435:26 warning 'message' is defined but never used no-unused-vars 435:35 warning 'messageConsumer' is defined but never used no-unused-vars /home/massakam/github/pulsar-client-node/tests/producer.test.js 20:24 error Unexpected use of file extension "js" for "../index.js" import/extensions /home/massakam/github/pulsar-client-node/tests/reader.test.js 21:24 error Unexpected use of file extension "js" for "../index.js" import/extensions ✖ 21 problems (13 errors, 8 warnings) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
