BewareMyPower commented on code in PR #303:
URL: https://github.com/apache/pulsar-client-cpp/pull/303#discussion_r1271665903
##########
tests/ProducerTest.cc:
##########
@@ -439,6 +439,69 @@ TEST_P(ProducerTest, testFlushNoBatch) {
client.close();
}
+TEST_P(ProducerTest, testFlushBatch) {
+ Client client(serviceUrl);
+
+ auto partitioned = GetParam();
+ const auto topicName = std::string("testFlushNoBatch") +
+ (partitioned ? "partitioned-" : "-no-partitioned-")
+
+ std::to_string(time(nullptr));
+
+ if (partitioned) {
+ // call admin api to make it partitioned
+ std::string url = adminUrl + "admin/v2/persistent/public/default/" +
topicName + "/partitions";
+ int res = makePutRequest(url, "5");
+ LOG_INFO("res = " << res);
+ ASSERT_FALSE(res != 204 && res != 409);
+ }
+
+ ProducerConfiguration producerConfiguration;
+ producerConfiguration.setBatchingEnabled(true);
+ producerConfiguration.setBatchingMaxMessages(10);
+ producerConfiguration.setBatchingMaxPublishDelayMs(1000);
+ producerConfiguration.setBatchingMaxAllowedSizeInBytes(4*1024*1024);
+
+ // test all messages in batch has been sent
+ Producer producer;
+ ASSERT_EQ(ResultOk, client.createProducer(topicName,
producerConfiguration, producer));
+
+ std::atomic_int needCallBack(100);
+ auto cb = [&needCallBack](Result code, const MessageId& msgId) {
+ ASSERT_EQ(code, ResultOk);
+ needCallBack.fetch_sub(1);
+ };
+
+ for (int i = 0; i < 100; ++i) {
+ Message msg = MessageBuilder().setContent("content").build();
+ producer.sendAsync(msg, cb);
+ }
+
+ producer.flush();
+ ASSERT_EQ(needCallBack.load(), 0);
+ producer.close();
+
Review Comment:
```suggestion
```
##########
tests/ProducerTest.cc:
##########
@@ -439,6 +439,69 @@ TEST_P(ProducerTest, testFlushNoBatch) {
client.close();
}
+TEST_P(ProducerTest, testFlushBatch) {
+ Client client(serviceUrl);
+
+ auto partitioned = GetParam();
+ const auto topicName = std::string("testFlushNoBatch") +
+ (partitioned ? "partitioned-" : "-no-partitioned-")
+
+ std::to_string(time(nullptr));
+
+ if (partitioned) {
+ // call admin api to make it partitioned
+ std::string url = adminUrl + "admin/v2/persistent/public/default/" +
topicName + "/partitions";
+ int res = makePutRequest(url, "5");
+ LOG_INFO("res = " << res);
+ ASSERT_FALSE(res != 204 && res != 409);
+ }
+
+ ProducerConfiguration producerConfiguration;
+ producerConfiguration.setBatchingEnabled(true);
+ producerConfiguration.setBatchingMaxMessages(10);
+ producerConfiguration.setBatchingMaxPublishDelayMs(1000);
+ producerConfiguration.setBatchingMaxAllowedSizeInBytes(4*1024*1024);
Review Comment:
```suggestion
producerConfiguration.setBatchingMaxAllowedSizeInBytes(4 * 1024 * 1024);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
