Demogorgon314 commented on code in PR #20677:
URL: https://github.com/apache/pulsar/pull/20677#discussion_r1272027011
##########
pulsar-common/src/main/java/org/apache/pulsar/common/topics/TopicCompactionStrategy.java:
##########
@@ -60,17 +65,27 @@ public interface TopicCompactionStrategy<T> {
*/
boolean shouldKeepLeft(T prev, T cur);
- static TopicCompactionStrategy load(String
topicCompactionStrategyClassName) {
+ default void handleSkippedMessage(String key, T cur) {
+ }
+
+
+ static TopicCompactionStrategy load(String tag, String
topicCompactionStrategyClassName) {
Review Comment:
This API should only use for extensible load managers. I added an annotation
to mark this as private, https://github.com/apache/pulsar/pull/20858 , please
help take a look at this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
