nodece opened a new pull request, #20861: URL: https://github.com/apache/pulsar/pull/20861
### Motivation https://github.com/apache/pulsar/pull/20496 introduces `getPermissionsAsync()` and `getSubscriptionPermissionsAsync()`, which without role and auth data parameters, I don't think this is the correct design in some concert. In the `AuthorizationProvider.java`, both grant and revoke permission methods have the role and auth data parameters, so I believe the get permission method also requires these parameters. For the current implement(`PulsarAuthorizationProvider.java`), #20496 is right, but we have to consider how third-party plugins store policy. ### Modifications - Add role and auth data parameters to `getPermissionsAsync()` and `getSubscriptionPermissionsAsync()` in the `AuthorizationProvider.java` - Fix method calls in the `v1/Namespaces.java` and `v1/Namespaces.java` ### Verifying this change - [ ] Make sure that the change passes the CI checks. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
