RobertIndie commented on PR #1062: URL: https://github.com/apache/pulsar-client-go/pull/1062#issuecomment-1649639638
Unfortunately, I couldn't reproduce it. I used `AuthenticationProviderTls` and set `authenticationRefreshCheckSeconds=5`. But it didn't refresh the authentication check. After checking the code, just found that `AuthenticationProviderTls` doesn't override `newAuthState` method so it is returning the `OneStageAuthenticationState`:https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java#L100-L105. The `OneStageAuthenticationState` will never be expired. Therefore it seems that is should never pass this condition: https://github.com/apache/pulsar/blob/b69f4efa6058c3f51885a61a2b3acb46f8b730f4/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L720-L722 So it won't trigger the refresh check. I'm not sure what I didn't set up correctly. Anyway, I'm +1 for your PR. But I'm trying to reproduce the issue to investigate it further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
