lifepuzzlefun commented on code in PR #20880:
URL: https://github.com/apache/pulsar/pull/20880#discussion_r1278544141
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java:
##########
@@ -167,6 +167,8 @@ public CompletableFuture<Void> connectionOpened(ClientCnx
cnx) {
return null;
});
} else {
+ LOG.warn("Can not connect to the transaction coordinator
because the protocol version {} is "
+ + "lower than 19",
cnx.getRemoteEndpointProtocolVersion());
registerToConnection(cnx);
Review Comment:
Just curious that if client protocol version lower than the expected
version？does any txn request will throw exception？It seems the Future just
completed as normal
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java:
##########
@@ -167,6 +167,8 @@ public CompletableFuture<Void> connectionOpened(ClientCnx
cnx) {
return null;
});
} else {
+ LOG.warn("Can not connect to the transaction coordinator
because the protocol version {} is "
+ + "lower than 19",
cnx.getRemoteEndpointProtocolVersion());
registerToConnection(cnx);
Review Comment:
Just curious that if client protocol version lower than the expected
version？does any txn request will throw exception？It seems the Future just
completed as normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
