Anonymitaet commented on code in PR #662: URL: https://github.com/apache/pulsar-site/pull/662#discussion_r1281693287
########## docs/develop-load-manager.md: ########## @@ -207,3 +103,216 @@ then all machines are approximately overloaded. In the case in which a broker's threshold, that broker is not considered for bundle assignment. If all brokers are overloaded, the bundle is randomly assigned. +## Enablement + +You can enable a simple, modular, or extensible load manager by following the steps below. + +### Enable simple load manager + +You can enable the simple load manager using one of the following methods: + +- Method 1 + + Update the value of [loadManagerClassName](https://github.com/apache/pulsar/blob/782e91fe327efe2c9c9107d6c679c2837d43935b/conf/broker.conf#L1309) to `org.apache.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl` in `conf/broker.conf`. + +- Method 2 + + Use the `pulsar-admin` tool. + + ```shell + pulsar-admin brokers update-dynamic-config \ + --config loadManagerClassName \ + --value org.apache.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl + ``` + + :::note + + Any mistakes in specifying the load manager will cause Pulsar to default to `SimpleLoadManagerImpl`. + + ::: Review Comment: @Demogorgon314 is this note correct here? ########## docs/develop-load-manager.md: ########## @@ -207,3 +103,216 @@ then all machines are approximately overloaded. In the case in which a broker's threshold, that broker is not considered for bundle assignment. If all brokers are overloaded, the bundle is randomly assigned. +## Enablement + +You can enable a simple, modular, or extensible load manager by following the steps below. + +### Enable simple load manager + +You can enable the simple load manager using one of the following methods: + +- Method 1 + + Update the value of [loadManagerClassName](https://github.com/apache/pulsar/blob/782e91fe327efe2c9c9107d6c679c2837d43935b/conf/broker.conf#L1309) to `org.apache.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl` in `conf/broker.conf`. + +- Method 2 + + Use the `pulsar-admin` tool. + + ```shell + pulsar-admin brokers update-dynamic-config \ + --config loadManagerClassName \ + --value org.apache.pulsar.broker.loadbalance.impl.SimpleLoadManagerImpl + ``` + + :::note + + Any mistakes in specifying the load manager will cause Pulsar to default to `SimpleLoadManagerImpl`. + + ::: + +### Enable modular load manager + +You can enable the modular load manager using one of the following methods: + +- Method 1 + + Update the value of [loadManagerClassName](https://github.com/apache/pulsar/blob/782e91fe327efe2c9c9107d6c679c2837d43935b/conf/broker.conf#L1309) to `org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl` in `conf/broker.conf`. + +- Method 2 + + Use the `pulsar-admin` tool. + + ```shell + pulsar-admin brokers update-dynamic-config \ + --config loadManagerClassName \ + --value org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl + ``` + + :::note + + Any mistakes in specifying the load manager will cause Pulsar to default to `SimpleLoadManagerImpl`. + + ::: Review Comment: @Demogorgon314 is this note correct here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
