poorbarcode commented on code in PR #20927:
URL: https://github.com/apache/pulsar/pull/20927#discussion_r1283532428
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -946,6 +946,7 @@ public void completeHandleFuture() {
public void exceptionHandleFuture(Throwable t) {
final boolean completedNow =
this.pendingAckHandleCompletableFuture.completeExceptionally(t);
+ persistentSubscription.getTopic().getSubscriptions().remove(subName);
Review Comment:
I do not agree with removing the subscription because it will make data lost
if users work as the following:
- create topic
- publish messages and consume messages.
- enable transaction and restart the broker.
- the subscription was removed if a pending ack store initializes failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
