JooHyukKim commented on code in PR #20709:
URL: https://github.com/apache/pulsar/pull/20709#discussion_r1285396178
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBase.java:
##########
@@ -26,17 +27,28 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
import java.util.function.Supplier;
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.admin.PulsarAdminException;
import org.apache.pulsar.client.admin.PulsarAdminException.ConnectException;
+import org.apache.pulsar.client.admin.internal.PulsarAdminImpl;
public abstract class CmdBase {
protected final JCommander jcommander;
private final Supplier<PulsarAdmin> adminSupplier;
private PulsarAdmin admin;
private IUsageFormatter usageFormatter;
+ /**
+ * Default read timeout in milliseconds.
+ * Used if not found from configuration data in {@link #getReadTimeoutMs()}
+ */
Review Comment:
Hmm, I don't think `doc-required` label is applicable anymore. The label
must have been along the way.
WDYT, @Anonymitaet ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
