blankensteiner commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285710492
########## tests/DotPulsar.Tests/ReaderTests.cs: ########## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Tests; + +using DotPulsar.Abstractions; +using DotPulsar.Extensions; +using FluentAssertions; +using System; +using System.Collections.Generic; +using System.Linq; +using System.Threading; +using System.Threading.Tasks; +using Xunit; +using Xunit.Abstractions; + +[Collection("Integration"), Trait("Category", "Integration")] +public class ReaderTests +{ + private readonly IntegrationFixture _fixture; + private readonly ITestOutputHelper _testOutputHelper; + + public ReaderTests(IntegrationFixture fixture, ITestOutputHelper testOutputHelper) + { + _fixture = fixture; + _testOutputHelper = testOutputHelper; + } + + [Fact] + public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll() + { + //Arrange + await using var client = CreateClient(); + const int numberOfMessages = 10; + var topicName = $"simple-produce-consume{Guid.NewGuid():N}"; + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); + } + + [Fact] + public async Task Messages_GivenPartitionedTopicWithMessages_ShouldConsumeAll() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 50; + var topicName = $"reader-with-3-partitions-test"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); Review Comment: Same question as above ########## tests/DotPulsar.Tests/ReaderTests.cs: ########## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Tests; + +using DotPulsar.Abstractions; +using DotPulsar.Extensions; +using FluentAssertions; +using System; +using System.Collections.Generic; +using System.Linq; +using System.Threading; +using System.Threading.Tasks; +using Xunit; +using Xunit.Abstractions; + +[Collection("Integration"), Trait("Category", "Integration")] +public class ReaderTests +{ + private readonly IntegrationFixture _fixture; + private readonly ITestOutputHelper _testOutputHelper; + + public ReaderTests(IntegrationFixture fixture, ITestOutputHelper testOutputHelper) + { + _fixture = fixture; + _testOutputHelper = testOutputHelper; + } + + [Fact] + public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll() Review Comment: We are not testing "Messages", since this is an extension method :-) ########## tests/DotPulsar.Tests/ReaderTests.cs: ########## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Tests; + +using DotPulsar.Abstractions; +using DotPulsar.Extensions; +using FluentAssertions; +using System; +using System.Collections.Generic; +using System.Linq; +using System.Threading; +using System.Threading.Tasks; +using Xunit; +using Xunit.Abstractions; + +[Collection("Integration"), Trait("Category", "Integration")] +public class ReaderTests +{ + private readonly IntegrationFixture _fixture; + private readonly ITestOutputHelper _testOutputHelper; + + public ReaderTests(IntegrationFixture fixture, ITestOutputHelper testOutputHelper) + { + _fixture = fixture; + _testOutputHelper = testOutputHelper; + } + + [Fact] + public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll() + { + //Arrange + await using var client = CreateClient(); + const int numberOfMessages = 10; + var topicName = $"simple-produce-consume{Guid.NewGuid():N}"; + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); Review Comment: Shouldn't we test for equality of messageIds and not just the count? ########## tests/DotPulsar.Tests/ReaderTests.cs: ########## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Tests; + +using DotPulsar.Abstractions; +using DotPulsar.Extensions; +using FluentAssertions; +using System; +using System.Collections.Generic; +using System.Linq; +using System.Threading; +using System.Threading.Tasks; +using Xunit; +using Xunit.Abstractions; + +[Collection("Integration"), Trait("Category", "Integration")] +public class ReaderTests +{ + private readonly IntegrationFixture _fixture; + private readonly ITestOutputHelper _testOutputHelper; + + public ReaderTests(IntegrationFixture fixture, ITestOutputHelper testOutputHelper) + { + _fixture = fixture; + _testOutputHelper = testOutputHelper; + } + + [Fact] + public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll() + { + //Arrange + await using var client = CreateClient(); + const int numberOfMessages = 10; + var topicName = $"simple-produce-consume{Guid.NewGuid():N}"; + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); + } + + [Fact] + public async Task Messages_GivenPartitionedTopicWithMessages_ShouldConsumeAll() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 50; + var topicName = $"reader-with-3-partitions-test"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); + } + + [Fact] + public async Task Messages_GivenPartitionedTopicWithMessages_ShouldReturnMessagesFromDifferentPartitions() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 20; + var topicName = $"reader-should-read-from-different-partitions-test"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + var foundNonNegativeOne = false; + foreach (var messageId in messageIds) + { + if (!messageId.Partition.Equals(-1)) + foundNonNegativeOne = true; + } + + foundNonNegativeOne.Should().Be(true); + } + + [Fact] + public async Task GetLastMessageIds_GivenTopicWithThreePartitions_ShouldHave3lastMessageId() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 10; + var topicName = $"reader_get_last_message_ids_should_have_3_last_message_ids"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var lastMessageIds = await reader.GetLastMessageIds(new CancellationToken()); + + //Assert + lastMessageIds.Count().Should().Be(3); Review Comment: Same as above ########## tests/DotPulsar.Tests/ReaderTests.cs: ########## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace DotPulsar.Tests; + +using DotPulsar.Abstractions; +using DotPulsar.Extensions; +using FluentAssertions; +using System; +using System.Collections.Generic; +using System.Linq; +using System.Threading; +using System.Threading.Tasks; +using Xunit; +using Xunit.Abstractions; + +[Collection("Integration"), Trait("Category", "Integration")] +public class ReaderTests +{ + private readonly IntegrationFixture _fixture; + private readonly ITestOutputHelper _testOutputHelper; + + public ReaderTests(IntegrationFixture fixture, ITestOutputHelper testOutputHelper) + { + _fixture = fixture; + _testOutputHelper = testOutputHelper; + } + + [Fact] + public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll() + { + //Arrange + await using var client = CreateClient(); + const int numberOfMessages = 10; + var topicName = $"simple-produce-consume{Guid.NewGuid():N}"; + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); + } + + [Fact] + public async Task Messages_GivenPartitionedTopicWithMessages_ShouldConsumeAll() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 50; + var topicName = $"reader-with-3-partitions-test"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + messageIds.Count.Should().Be(numberOfMessages); + } + + [Fact] + public async Task Messages_GivenPartitionedTopicWithMessages_ShouldReturnMessagesFromDifferentPartitions() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 20; + var topicName = $"reader-should-read-from-different-partitions-test"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var messageIds = new List<MessageId>(); + await foreach (var message in reader.Messages()) + { + messageIds.Add(message.MessageId); + + if (messageIds.Count != numberOfMessages) + continue; + + break; + } + + //Assert + var foundNonNegativeOne = false; + foreach (var messageId in messageIds) + { + if (!messageId.Partition.Equals(-1)) + foundNonNegativeOne = true; + } + + foundNonNegativeOne.Should().Be(true); + } + + [Fact] + public async Task GetLastMessageIds_GivenTopicWithThreePartitions_ShouldHave3lastMessageId() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 10; + var topicName = $"reader_get_last_message_ids_should_have_3_last_message_ids"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var lastMessageIds = await reader.GetLastMessageIds(new CancellationToken()); + + //Assert + lastMessageIds.Count().Should().Be(3); + } + + [Fact] + public async Task GetLastMessageIds_GivenTopicWithThreePartitions_ShouldHaveThreePartitions() + { + //Arrange + const int partitions = 3; + const int numberOfMessages = 10; + var topicName = $"reader_get_last_message_ids_should_have_3_topics"; + _fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", partitions); + + await using var client = CreateClient(); + const string content = "test-message"; + + await using var producer = client.NewProducer(Schema.String) + .Topic(topicName) + .Create(); + + await using var reader = client.NewReader(Schema.String) + .StartMessageId(MessageId.Earliest) + .Topic(topicName) + .Create(); + + for (var i = 0; i < numberOfMessages; i++) + { + await producer.Send(content); + } + + //Act + var lastMessageIds = await reader.GetLastMessageIds(); + + var shouldHave = new[] { "reader_get_last_message_ids_should_have_3_topics-partition-0", "reader_get_last_message_ids_should_have_3_topics-partition-1", "reader_get_last_message_ids_should_have_3_topics-partition-2" }; + + //Assert + lastMessageIds.Select(x => x.Topic).ToArray().Should().Contain(shouldHave); Review Comment: Contain or exactly the same? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
