entvex commented on code in PR #162:
URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285760456


##########
tests/DotPulsar.Tests/ConsumerTests.cs:
##########
@@ -70,6 +71,153 @@ public async Task 
Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM
         consumed.Should().BeEquivalentTo(produced);
     }
 
+    [Fact]
+    public async Task 
GetLastMessageId_GivenPartitionedTopic_ShouldThrowException()
+    {
+        //Arrange
+        var testRunId = Guid.NewGuid().ToString("N");
+        const int partitions = 3;
+        var topicName = 
$"persistent://public/default/consumer-tests-{testRunId}";
+
+        _fixture.CreatePartitionedTopic(topicName, partitions);
+
+        await using var client = PulsarClient.Builder()
+            .ServiceUrl(_fixture.ServiceUrl)
+            .Authentication(AuthenticationFactory.Token(ct => 
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+            .Build();
+
+        var consumer = client.NewConsumer(Schema.ByteArray)
+            .ConsumerName($"consumer-{testRunId}")
+            .InitialPosition(SubscriptionInitialPosition.Earliest)
+            .SubscriptionName($"subscription-{testRunId}")
+            .Topic(topicName)
+            .Create();
+
+        //Act
+        var exception = await Record.ExceptionAsync(() => 
consumer.GetLastMessageId().AsTask());
+
+        //Assert
+        exception.Should().BeOfType<NotSupportedException>();
+    }
+
+    [Theory]
+    [InlineData(10000)]
+    public async Task 
Messages_GivenPartitionedTopicWithMessages_ShouldConsumeAll(int 
numberOfMessages)
+    {
+        //Arrange
+        var testRunId = Guid.NewGuid().ToString("N");
+        const int partitions = 3;
+        var topicName = $"consumer-with-3-partitions-test";
+
+        
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", 
partitions);
+
+        await using var client = PulsarClient.Builder()
+            .ServiceUrl(_fixture.ServiceUrl)
+            .Authentication(AuthenticationFactory.Token(ct => 
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+            .Build();
+
+        //Act
+        await using var consumer = client.NewConsumer(Schema.ByteArray)
+            .ConsumerName($"consumer-{testRunId}")
+            .InitialPosition(SubscriptionInitialPosition.Earliest)
+            .SubscriptionName($"subscription-{testRunId}")
+            .Topic(topicName)
+            .Create();
+
+        await using var producer = client.NewProducer(Schema.ByteArray)
+            .ProducerName($"producer-{testRunId}")
+            .Topic(topicName)
+            .Create();
+
+        var cts = new CancellationTokenSource(TimeSpan.FromSeconds(60));
+
+        var produced = await ProduceMessages(producer, numberOfMessages, 
cts.Token);
+        var consumed = await ConsumeMessages(consumer, numberOfMessages, 
cts.Token);
+
+        //Assert
+        consumed.Should().BeEquivalentTo(produced);
+    }
+
+    [Fact]
+    public async Task 
GetLastMessageIds_GivenMessageIdsFrom3Partitions_ShouldHave3Partitions()
+    {
+        //Arrange
+        var testRunId = Guid.NewGuid().ToString("N");
+        const int partitions = 3;
+        const int numberOfMessages = 10;
+        var topicName = $"consumer_get_last_message_ids_should_have_3_topics";
+        
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", 
partitions);
+
+        await using var client = PulsarClient.Builder()
+            .ServiceUrl(_fixture.ServiceUrl)
+            .Authentication(AuthenticationFactory.Token(ct => 
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+            .Build();
+
+        await using var producer = client.NewProducer(Schema.String)
+            .Topic(topicName)
+            .Create();
+
+        await using var consumer = client.NewConsumer(Schema.ByteArray)
+            .ConsumerName($"consumer-{testRunId}")
+            .InitialPosition(SubscriptionInitialPosition.Earliest)
+            .SubscriptionName($"subscription-{testRunId}")
+            .Topic(topicName)
+            .Create();
+
+        const string content = "test-message";
+        for (var i = 0; i < numberOfMessages; i++)
+        {
+            await producer.Send(content);
+        }
+
+        string[] expected = { 
"consumer_get_last_message_ids_should_have_3_topics-partition-0", 
"consumer_get_last_message_ids_should_have_3_topics-partition-1", 
"consumer_get_last_message_ids_should_have_3_topics-partition-2" };
+
+        //Act
+        var actual = await consumer.GetLastMessageIds();
+
+        //Assert
+        actual.Select(x => 
x.Topic).Should().HaveCount(3).And.Contain(expected);
+    }
+
+    [Fact]
+    public async Task 
GetLastMessageIds_Given3Partitions_ShouldHave3lastMessageIds()
+    {
+        //Arrange
+        var testRunId = Guid.NewGuid().ToString("N");
+        const int partitions = 3;
+        const int numberOfMessages = 10;
+        var topicName = 
$"consumer_get_last_message_ids_should_have_3_last_message_ids";
+        
_fixture.CreatePartitionedTopic($"persistent://public/default/{topicName}", 
partitions);
+
+        await using var client = PulsarClient.Builder()
+            .ServiceUrl(_fixture.ServiceUrl)
+            .Authentication(AuthenticationFactory.Token(ct => 
ValueTask.FromResult(_fixture.CreateToken(Timeout.InfiniteTimeSpan))))
+            .Build();
+
+        await using var producer = client.NewProducer(Schema.String)
+            .Topic(topicName)
+            .Create();
+
+        await using var consumer = client.NewConsumer(Schema.ByteArray)
+            .ConsumerName($"consumer-{testRunId}")
+            .InitialPosition(SubscriptionInitialPosition.Earliest)
+            .SubscriptionName($"subscription-{testRunId}")
+            .Topic(topicName)
+            .Create();
+
+        const string content = "test-message";
+        for (var i = 0; i < numberOfMessages; i++)
+        {
+            await producer.Send(content);
+        }
+
+        //Act
+        var lastMessageIds = await consumer.GetLastMessageIds();
+
+        //Assert
+        lastMessageIds.Should().HaveCount(3);

Review Comment:
   We are looking for any 3. Because we have no idea of what the specific IDs 
should be. But we know that there are 3 partitions, therefore we should have 3 
back. One for each topic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to