heesung-sn commented on code in PR #20948:
URL: https://github.com/apache/pulsar/pull/20948#discussion_r1286226585
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingSharedTest.java:
##########
@@ -211,6 +212,32 @@ private static String createChunkedMessage(int numChunks) {
return Schema.STRING.decode(payload);
}
+ @Test
+ public void testDuplicateForChunkMessage() throws Exception {
+ String topicName =
"persistent://my-property/my-ns/testDuplicateForChunkMessage";
+ String producerName = "test-producer";
+ pulsarClient =
PulsarClient.builder().serviceUrl(pulsar.getBrokerServiceUrl()).build();
+ // consumer
+ Consumer<byte[]> consumer = pulsarClient
+ .newConsumer()
+ .subscriptionName("test-sub")
+ .topic(topicName)
+ .subscribe();
+ // producer
+ Producer<String> partProducer = pulsarClient
+ .newProducer(Schema.AVRO(String.class))
+ .producerName(producerName)
+ .topic(topicName)
+ .enableChunking(true)
+ .enableBatching(false)
+ .create();
+ int messageSize = 6000; // payload size in KB
+ String message = "a".repeat(messageSize * 1000);
+ partProducer.newMessage().value(message).send();
Review Comment:
Aren't we supposed to test dedup messages? Is this a validate dedup +
chunking test?
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingSharedTest.java:
##########
@@ -211,6 +212,32 @@ private static String createChunkedMessage(int numChunks) {
return Schema.STRING.decode(payload);
}
+ @Test
+ public void testDuplicateForChunkMessage() throws Exception {
+ String topicName =
"persistent://my-property/my-ns/testDuplicateForChunkMessage";
+ String producerName = "test-producer";
+ pulsarClient =
PulsarClient.builder().serviceUrl(pulsar.getBrokerServiceUrl()).build();
+ // consumer
+ Consumer<byte[]> consumer = pulsarClient
+ .newConsumer()
+ .subscriptionName("test-sub")
+ .topic(topicName)
+ .subscribe();
+ // producer
+ Producer<String> partProducer = pulsarClient
+ .newProducer(Schema.AVRO(String.class))
+ .producerName(producerName)
+ .topic(topicName)
+ .enableChunking(true)
+ .enableBatching(false)
+ .create();
+ int messageSize = 6000; // payload size in KB
+ String message = "a".repeat(messageSize * 1000);
+ partProducer.newMessage().value(message).send();
+ Message<byte[]> msg = consumer.receive(5, TimeUnit.SECONDS);
Review Comment:
Please assert the expected sequence id and message contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
