poorbarcode commented on code in PR #20951:
URL: https://github.com/apache/pulsar/pull/20951#discussion_r1286626170


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -195,6 +195,10 @@ public class PersistentTopic extends AbstractTopic 
implements Topic, AddEntryCal
     private final TopicName shadowSourceTopic;
 
     static final String DEDUPLICATION_CURSOR_NAME = "pulsar.dedup";
+
+    public static boolean isDedupCursorName(String name) {
+        return name.equals(DEDUPLICATION_CURSOR_NAME);

Review Comment:
   Use `DEDUPLICATION_CURSOR_NAME .equals(curosrName)` is better, because the 
constant variable is never be `null`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to