michaeljmarshall commented on PR #20903: URL: https://github.com/apache/pulsar/pull/20903#issuecomment-1670238177
> Elasticsearch Config(Nested configurations): We can improve `IOConfigUtils` to support it. Right? It's possible, but it would likely require a change/expansion to the way the `FieldDoc` annotation works. However, fixing it for Elasticsearch does not solve the general problem. > RabbitMQ Config(Not using IOConfigUtils to load config): We can find and fix connectors for these same problems. Right? I already proposed this as part of the PIP here: https://github.com/apache/pulsar/pull/20902. > * Kafka Config(Use kafka properties map): > > * Perhaps we should refine these keys to create configurations separately > * Or we can enhance annotations to support set sensitive key names, such as: > > > ```java > @FieldDoc( > defaultValue = "", > help = "Config properties to pass to the kafka connector." > sensitiveNames="password-1, password-2" > ) > private Map<String, String> kafkaConnectorConfigProperties; > ``` The Kafka Config is the real reason for this PIP. We need arbitrary interpolation because the Kafka Config works as a wrapper. For example, it is possible to configure it with any connector that works with Kafka. See https://github.com/datastax/pulsar-3rdparty-connector for many third party connectors that are simply plugged into the Kafka Adapter Connector without any additional work. Since it is a wrapper, it is not possible to annotate the relevant fields with a custom Pulsar annotation (`FieldDoc`). Instead, I propose we find a more general solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
