michaeljmarshall commented on code in PR #20933:
URL: https://github.com/apache/pulsar/pull/20933#discussion_r1288575737
##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/TestZKServer.java:
##########
@@ -25,33 +25,31 @@
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.OutputStream;
-import java.net.InetSocketAddress;
+import java.lang.reflect.Field;
import java.net.Socket;
+import java.util.Properties;
-import java.nio.charset.StandardCharsets;
-
+import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.io.FileUtils;
-import org.apache.zookeeper.KeeperException;
import org.apache.zookeeper.server.ContainerManager;
-import org.apache.zookeeper.server.NIOServerCnxnFactory;
-import org.apache.zookeeper.server.Request;
-import org.apache.zookeeper.server.RequestProcessor;
import org.apache.zookeeper.server.ServerCnxnFactory;
-import org.apache.zookeeper.server.SessionTracker;
import org.apache.zookeeper.server.ZooKeeperServer;
+import org.apache.zookeeper.server.ZooKeeperServerMain;
+import org.apache.zookeeper.server.embedded.ExitHandler;
+import org.apache.zookeeper.server.embedded.ZooKeeperServerEmbedded;
import org.assertj.core.util.Files;
+import org.junit.platform.commons.util.ReflectionUtils;
Review Comment:
In looking into the `ReflectionUtils` source code, I see the following
warning:
```java
/**
* Collection of utilities for working with the Java reflection APIs.
*
* <h2>DISCLAIMER</h2>
*
* <p>These utilities are intended solely for usage within the JUnit
framework
* itself. <strong>Any usage by external parties is not supported.</strong>
* Use at your own risk!
*
* <p>Some utilities are published via the maintained {@code
ReflectionSupport}
* class.
*
* @since 1.0
* @see org.junit.platform.commons.support.ReflectionSupport
*/
@API(status = INTERNAL, since = "1.0")
public final class ReflectionUtils
```
We might need to refactor this part of the PR. What is your opinion
@eolivelli?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
