liangyepianzhou commented on code in PR #20948:
URL: https://github.com/apache/pulsar/pull/20948#discussion_r1289445853
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -594,9 +595,9 @@ private void updateMessageMetadata(final MessageMetadata
msgMetadata, final int
}
}
- private long updateMessageMetadataSequenceId(final MessageMetadata
msgMetadata) {
+ private long updateMessageMetadataSequenceId(final MessageMetadata
msgMetadata, boolean isChunk) {
final long sequenceId;
- if (!msgMetadata.hasSequenceId()) {
+ if (!msgMetadata.hasSequenceId() || isChunk) {
Review Comment:
~~Yeah, I will send an email to discuss it.~~
I optimized the logic. And now, it should not be a breaking change, because
its behavior for users wouldn’t change.
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -594,9 +595,9 @@ private void updateMessageMetadata(final MessageMetadata
msgMetadata, final int
}
}
- private long updateMessageMetadataSequenceId(final MessageMetadata
msgMetadata) {
+ private long updateMessageMetadataSequenceId(final MessageMetadata
msgMetadata, boolean isChunk) {
final long sequenceId;
- if (!msgMetadata.hasSequenceId()) {
+ if (!msgMetadata.hasSequenceId() || isChunk) {
Review Comment:
~~Yeah, I will send an email to discuss it.~~
I optimized the logic. And now, it should not be a breaking change, because
its behavior for users wouldn’t change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
