thetumbled opened a new pull request, #20970: URL: https://github.com/apache/pulsar/pull/20970
### Motivation Load balance module in pulsar broker pose greate pressure on zk. <img width="288" alt="image" src="https://github.com/apache/pulsar/assets/52550727/f85fad25-5d11-4b01-a325-d2d784360413";> <img width="299" alt="image" src="https://github.com/apache/pulsar/assets/52550727/75178de4-d7d9-4522-8af5-b23415560b78";> Currently, `ModularLoadManagerImpl` is the main `LoadManager` in 2.x version, which work as a centralized way. Most of the time, leader broker take the responsibility of shedding and assignning, while followers update their load data to zk for leader. Leader broker retrieve load data of all brokers in the cluster to make decision. But, i found that not only leader will retrieve all load data (include LocalBrokerData and BundleData), but also followers, which is unnecessary and pose greate pressure to zk. ### Modifications Disable load data retrieve for followers. ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
