shibd commented on PR #20903:
URL: https://github.com/apache/pulsar/pull/20903#issuecomment-1674570878
Hi, @michaeljmarshall. Thanks for your explanation. I got it.
I think we can avoid adding a new config:
`interpolate_secrets_into_config_map`.
What's the problem with us calling the method by default?
```
private static void interpolateSecretsIntoConfigs(SecretsProvider
secretsProvider, Map<String, Object> configs)
```
Only when the user uses placeholders will it merge secrets to the config
map, right?
```
"username": "${username}",
"password": "${password}",
```
This way we just need to explain to the user that we provide a new way to
set secrets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
