[pulsar] branch master updated: [improve][bk] Improve getIsolationGroup by avoid creating arrayList (#20952)

[houxiaoyu]

This is an automated email from the ASF dual-hosted git repository.

houxiaoyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 64cd7535996 [improve][bk] Improve getIsolationGroup by avoid creating 
arrayList (#20952)
64cd7535996 is described below

commit 64cd7535996c6da07bedd7d06b1c1d1477c23287
Author: houxiaoyu <houxia...@apache.org>
AuthorDate: Sat Aug 12 14:18:32 2023 +0800

    [improve][bk] Improve getIsolationGroup by avoid creating arrayList (#20952)
    
    ### Motivation
    
    Minor improve `getIsolationGroup` by avoid creating arrayList. And it'  
beneficial to GC
    
    ### Modifications
    
    `new HashSet<>(Arrays.asList(...))` -> `Sets.newHashSet(...)`
---
 .../bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
 
b/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
index 2594798485a..164677ca9c6 100644
--- 
a/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
+++ 
b/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
@@ -19,8 +19,8 @@
 package org.apache.pulsar.bookie.rackawareness;
 
 import static 
org.apache.pulsar.bookie.rackawareness.BookieRackAffinityMapping.METADATA_STORE_INSTANCE;
+import com.google.common.collect.Sets;
 import io.netty.util.HashedWheelTimer;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
@@ -166,12 +166,12 @@ public class IsolatedBookieEnsemblePlacementPolicy 
extends RackawareEnsemblePlac
             String secondaryIsolationGroupString = ConfigurationStringUtil
                     
.castToString(properties.getOrDefault(SECONDARY_ISOLATION_BOOKIE_GROUPS, ""));
             if (!primaryIsolationGroupString.isEmpty()) {
-                pair.setLeft(new 
HashSet<>(Arrays.asList(primaryIsolationGroupString.split(","))));
+                
pair.setLeft(Sets.newHashSet(primaryIsolationGroupString.split(",")));
             } else {
                 pair.setLeft(Collections.emptySet());
             }
             if (!secondaryIsolationGroupString.isEmpty()) {
-                pair.setRight(new 
HashSet<>(Arrays.asList(secondaryIsolationGroupString.split(","))));
+                
pair.setRight(Sets.newHashSet(secondaryIsolationGroupString.split(",")));
             } else {
                 pair.setRight(Collections.emptySet());
             }