mattisonchao commented on code in PR #20984:
URL: https://github.com/apache/pulsar/pull/20984#discussion_r1292934520
##########
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java:
##########
@@ -69,16 +69,14 @@ public CompactedTopicImpl(BookKeeper bk) {
@Override
public CompletableFuture<CompactedTopicContext>
newCompactedLedger(Position p, long compactedLedgerId) {
- synchronized (this) {
Review Comment:
We can leave this lock here because JVM is smart enough to distinguish if we
need it. or we can issue another PR to remove this lock to get a clear context.
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
