lifepuzzlefun commented on code in PR #20983:
URL: https://github.com/apache/pulsar/pull/20983#discussion_r1299065324
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -247,6 +248,12 @@ protected TopicStatsHelper initialValue() {
// Record the last time a data message (ie: not an internal Pulsar marker)
is published on the topic
private volatile long lastDataMessagePublishedTimestamp = 0;
+
+ // Record the total expired subscription, if enable subscription
expiration feature
+ private static final AtomicLongFieldUpdater<PersistentTopic>
EXPIRED_SUBSCRIPTION_NUMBERS_UPDATER =
+ AtomicLongFieldUpdater.newUpdater(PersistentTopic.class,
"expiredSubscriptionNumbers");
+ private volatile long expiredSubscriptionNumbers = 0L;
Review Comment:
agree, it is added only for unit test. now i figure out another way to check
the logic. PTAL again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
