This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new dbbaddb6dbd [improve][pip] PIP-293: Delete config
`disableBrokerInterceptors` (#20993)
dbbaddb6dbd is described below
commit dbbaddb6dbdf2b5a2eaaa93a1ece37a31326a42b
Author: Jiwei Guo <[email protected]>
AuthorDate: Mon Aug 21 11:39:24 2023 +0800
[improve][pip] PIP-293: Delete config `disableBrokerInterceptors` (#20993)
---
pip/{pip-274.md => pip-276.md} | 0
pip/pip_293.md | 20 ++++++++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/pip/pip-274.md b/pip/pip-276.md
similarity index 100%
rename from pip/pip-274.md
rename to pip/pip-276.md
diff --git a/pip/pip_293.md b/pip/pip_293.md
new file mode 100644
index 00000000000..a03ad189ba7
--- /dev/null
+++ b/pip/pip_293.md
@@ -0,0 +1,20 @@
+# Motivation
+
+There is a config in ServiceConfiguration called `disableBrokerInterceptors`
introduced by [#8157](https://github.com/apache/pulsar/pull/8157), which seems
to disable the broker interceptor, but is commented for testing only.
+Actually, whether to enable the interceptor depends on whether the broker is
loaded into the interceptors.
[#10489](https://github.com/apache/pulsar/pull/10489) kept the same
implementation.
+But [#20422](https://github.com/apache/pulsar/pull/20422) has changed the
behavior, it uses `disableBrokerInterceptors` to judge whether to enable the
interceptor, which caused an NPE issue mentioned in
[#20710](https://github.com/apache/pulsar/pull/20710).
+This `disableBrokerInterceptors` config is very confusing, so we decide to
delete it.
+
+# Goals
+
+Delete config `disableBrokerInterceptors`.
+
+
+# Backward & Forward Compatibility
+
+No backward & forward compatibility issue
+
+# Links
+
+* Mailing List discussion thread:
https://lists.apache.org/thread/vqf5qcwv3rh2y1r62gw0dnpn0xznq9p0
+* Mailing List voting thread:
https://lists.apache.org/thread/o11otjlywgd0s8dsv7dg9s8msswdfspp
